Ethernet: Fix out of bounds memset on reset DHCP lease #3307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See discussion in arduino/Arduino#6337 |
|
Shouldn't that be memset(blah, 0, sizeof(blah))? I mean use sizeof()
instead of a magic number like "4".
…On May 30, 2017 2:45 AM, "Ville Skyttä" ***@***.***> wrote:
Closed #3307 <#3307>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#3307 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AQC6BvIgGRuORwNghtuDIkKU9I4h44jvks5r-7sigaJpZM4Np3i1>
.
|
|
Well kind of, I suppose. But then again, the 20 and the out of bounds memset is apparently intentional here, see arduino/Arduino#6337 (i.e. the 20 means |
|
I understand the meaning of the magic number, I'm just asking about
robustness and good coding practices. Also, being explicit with sizeof()
tells anyone who reads the code exactly what is being memset().
…On May 30, 2017 3:26 AM, "Ville Skyttä" ***@***.***> wrote:
Well kind of, I suppose. But then again, the 20 and the out of bounds
memset is apparently intentional here, see arduino/Arduino#6337
<arduino/Arduino#6337> (i.e. the 20 means sizeof(_dhcpSubnetMask)
+ sizeof(_dhcpGatewayIp) + sizeof(_dhcpLocalIp) + sizeof(_dhcpDhcpServerIp)
+ sizeof(_dhcpDnsServerIp) IIUC)
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#3307 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AQC6BhXxXxL-iG4Nm16BwLbkGtLh_UbIks5r-8SZgaJpZM4Np3i1>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.